work-on-core #50

Merged

christof.schadt merged 27 commits from work-on-core into main 2026-07-14 21:23:53 +02:00

Conversation 0 Commits 27 Files changed 49 +4677 -873

christof.schadt commented 2026-07-11 15:26:15 +02:00

Owner

Copy link

No description provided.

christof.schadt added 23 commits 2026-07-11 15:26:15 +02:00

chore: update max PDU size to 256KiB 42add7ca43

chore: do not parse the full wado-retrieved instance b5c173ff32

chore: parallel streaming 58dfd8ce58

chore: improve parsing da40c2b3ba

chore: optimize UID parsing 46d2522cbe

chore: improve byte handling 5643e2f061

chore: do not drain full Study e6f0e08dd1

chore: use a shared http client ... a589135e5b

chore: use reqwest gzip feature
fix: empty query attributes were not forwarded

chore: plan to optimize dicomweb frontend/dimse backend 531d5ef73b

chore: plan to optimize archive 2c17182c17

chore: extract shared part10 helpers module ... 230adbf977

Move the meta-only part parser (wado client) and the Part-10 header
synthesis (stow client) into dicomweb::part10 so the DICOMweb server
side can reuse them (plan-09 change 1).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

fix: STOW-RS ingest keeps the original transfer syntax ... 28a4a176d0

Parse only the File Meta group of each part and forward the dataset
bytes verbatim instead of decoding and force-re-encoding everything to
Explicit VR LE (which would corrupt compressed pixel data). Study and
Series UIDs now come from the early-terminating token read
(plan-09 change 2).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

chore: build WADO-RS parts without re-parsing the dataset ... 3cf17f08b6

Synthesize the Part-10 header from the instance identifiers and append
the stored dataset bytes verbatim instead of decoding and re-serializing
every instance (plan-09 change 3).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

chore: stream the DIMSE SCU retrieve ... b379b0abe6

execute_cget/execute_cmove gain visitor variants that hand each
instance over as its C-STORE sub-operation arrives, before the
acknowledgement — a slow consumer throttles the PACS via DIMSE flow
control. Backend::Dimse::retrieve returns a bounded channel immediately
instead of collecting the whole transfer (plan-09 change 4).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

chore: stream the WADO-RS response body ... ab198ca62d

Peek the first instance to decide 204 vs 200, then stream each
multipart part into the body as it arrives from the backend
(Body::from_stream over the retrieve channel). Time-to-first-byte
drops to one instance; a mid-stream error truncates the body without
the closing delimiter (plan-09 change 5).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

chore: deliver STOW-RS batches over one DIMSE association ... c240afb537

New BackendTrait::store_batch with per-instance outcomes; the DIMSE
backend negotiates once with the batch's deduplicated (SOP class,
transfer syntax) pairs and sends every instance on that association
instead of opening one per instance (plan-09 change 6).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

chore: parse STOW-RS request bodies as they arrive ... eb5e985c0f

Feed multer from the axum body stream instead of buffering the whole
request in memory first (plan-09 change 7).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

chore: index archive instances via sparse dataset read ... 80502f2f84

New read_sparse_dataset on dicom-parser's lazy token reader: only the
indexed attributes are materialized, sequence payloads (e.g. RTSTRUCT
contour data) are skipped via seeks, the scan stops before PixelData,
and SpecificCharacterSet is always read so text decoding stays correct.
The archive store path no longer parses whole instances for 38 metadata
columns (plan-10 change 1).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

chore: reconcile indexes from file headers only ... f26bf16fb6

decode_stored_dataset and the legacy transfer-syntax inference use the
sparse read, so an index rebuild costs the per-file header region
instead of decoding whole instances; full decode remains as a fallback
(plan-10 change 2).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

chore: zero-copy archive Part-10 wrap and unwrap ... d367e978ca

Write files as two writes (shared synthesized header + dataset bytes
verbatim) instead of concatenating the whole instance in memory, and
unwrap on read via a Bytes slice instead of copying the dataset out.
On-disk format unchanged: still self-describing Part-10
(plan-10 change 3).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

chore: answer list_sop_classes from the archive index ... 0ca6d3e028

One SELECT DISTINCT per retrieve scope, so C-MOVE/SEND-RS out of the
archive negotiates the exact stored SOP classes instead of the 89-class
fallback list (plan-10 change 4, closes the plan-08 follow-up).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

chore: archive store_batch shares one transaction ... 4cebcdd068

Batch stores extract metadata and write files per instance, then insert
every index row inside a single SQLite transaction (one WAL commit and
one blocking task per STOW request instead of one per instance); a bad
instance fails only its own outcome (plan-10 change 5).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

chore: keep reconcile micro-benchmark, defer parallel indexing ... c76378ff9f

200 x 1 MiB files reindex in ~99 ms after the sparse-read switch
(~0.5 ms/file), so plan-10 change 6 (parallel reconcile) is not needed;
the ignored benchmark stays for future verification.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

christof.schadt added 1 commit 2026-07-11 15:27:44 +02:00

Merge branch 'main' into work-on-core fd7e477cfa

christof.schadt added 1 commit 2026-07-13 08:15:11 +02:00

chore: make FHIR server more robust f3250b534f

christof.schadt added 1 commit 2026-07-13 13:34:35 +02:00

chore: fix several minor issues 7568eacbd1

christof.schadt added 1 commit 2026-07-13 20:05:46 +02:00

chore: test HAPI FHIR server via docker a879ca04cd

christof.schadt merged commit 24c107d8ee into main 2026-07-14 21:23:52 +02:00

christof.schadt deleted branch work-on-core 2026-07-14 21:23:53 +02:00

christof.schadt referenced this pull request from a commit 2026-07-14 21:24:09 +02:00

Merge pull request 'work-on-core' (#50) from work-on-core into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

wontfix

This won't be fixed

No labels

bug

duplicate

enhancement

help wanted

invalid

question

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

IHE-RO-Tooling/dicom-gateway!50

No description provided.