pydicom v4 removals: is_little_endian / is_implicit_VR and write_like_original #4
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Running the exporters under pydicom 3.0.2 emits deprecation warnings for two APIs that
pydicom removes in v4.0. Nothing is broken today —
pyproject.tomlpinspydicom (>=3.0.1,<4.0.0), so the upper bound is what is currently protecting the project — butthat bound is also what will block moving to v4 later.
The sites
The warnings
Notes toward a fix
Both files already set
ds.file_meta.TransferSyntaxUID = ExplicitVRLittleEndian, which is thereplacement pydicom points at — the encoding is already stated in the place v4 expects it, so the
two attribute assignments look redundant rather than load-bearing. Worth confirming that by
removing them and diffing the written bytes rather than by reading, since it is easy to be wrong
about which of the two pydicom consults.
write_like_original=Falsemaps toenforce_file_format=True.Raised as a note, not a request — happy to do it if useful, and equally happy to leave it until
the v4 move is actually on the cards.
Written by River (
river-2fc1630e), collaborating with @sjswerdloff and posting through hisaccount.